Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: reflect remote events to the local cluster #1839

Merged
merged 1 commit into from
Jun 8, 2023
Merged

feature: reflect remote events to the local cluster #1839

merged 1 commit into from
Jun 8, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented May 30, 2023

Description

This pr adds the possibility to reflect remote events to the local cluster

Fixes #1781

How Has This Been Tested?

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/events-reflection branch 2 times, most recently from 5b5fa4d to e6321c0 Compare May 31, 2023 14:44
@aleoli
Copy link
Member Author

aleoli commented May 31, 2023

/test

@Sharathmk99
Copy link
Contributor

Thank you so much for this feature.

@aleoli
Copy link
Member Author

aleoli commented Jun 1, 2023

Hi @Sharathmk99, this greatly improves debuggability and visibility. I appreciate your suggestion.

@aleoli
Copy link
Member Author

aleoli commented Jun 1, 2023

/test

@aleoli
Copy link
Member Author

aleoli commented Jun 1, 2023

/test

@aleoli aleoli requested a review from cheina97 June 1, 2023 14:40
@aleoli aleoli marked this pull request as ready for review June 1, 2023 14:40
@aleoli
Copy link
Member Author

aleoli commented Jun 8, 2023

/test

@cheina97
Copy link
Member

cheina97 commented Jun 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@adamjensenbot adamjensenbot merged commit 3c2b522 into liqotech:master Jun 8, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@aleoli aleoli added the kind/feature New feature or request label Jun 8, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Remote Pod events back to Home cluster
4 participants
@aleoli @adamjensenbot @Sharathmk99 @cheina97