Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NodeSelector, Toleration and Affinity for CreateSecret Job #1843

Conversation

Sharathmk99
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1842

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Local

@adamjensenbot
Copy link
Collaborator

Hi @Sharathmk99. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@Sharathmk99 Sharathmk99 force-pushed the fix/job-missing-nodeselector-toleration branch 3 times, most recently from ae9c89c to 97a6762 Compare June 1, 2023 15:45
@Sharathmk99
Copy link
Contributor Author

PR is ready for review. Thanks

@Sharathmk99 Sharathmk99 force-pushed the fix/job-missing-nodeselector-toleration branch 2 times, most recently from d23da2e to 13be1ae Compare June 8, 2023 08:14
@aleoli
Copy link
Member

aleoli commented Jun 8, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the fix/job-missing-nodeselector-toleration branch from 13be1ae to 4987071 Compare June 8, 2023 08:54
@aleoli
Copy link
Member

aleoli commented Jun 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@adamjensenbot adamjensenbot merged commit f268c65 into liqotech:master Jun 8, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@cheina97 cheina97 added the kind/feature New feature or request label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeSelector, Toleration & Affinity missing fro CreateSecret Job
4 participants