Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqoctl: confirm #1849

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Liqoctl: confirm #1849

merged 1 commit into from
Jun 5, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Jun 1, 2023 •
edited

Description

This PR adds a confirmation prompt to potentially distructive commands.

The affected commands are:

  • uninstall
  • unpeer (in-band and out-of-band)
  • unoffload

The flag --skip-confirm has been added and enabled globally for all the commands. It allows skipping the confirmation prompt.

Screenshot

image

How Has This Been Tested?

  • Locally with KinD

@cheina97 cheina97 changed the title Liqoctl:confirm Liqoctl: confirm Jun 1, 2023
@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/liqoctlWarning branch 4 times, most recently from 418c49d to fadf8ea Compare June 1, 2023 15:28
@cheina97
Copy link
Member Author

cheina97 commented Jun 1, 2023

/rebase test=true

@cheina97 cheina97 marked this pull request as ready for review June 1, 2023 15:29
@cheina97 cheina97 requested review from aleoli and fra98 June 1, 2023 15:40
@cheina97
Copy link
Member Author

cheina97 commented Jun 1, 2023

/rebase test=true

2 similar comments
@cheina97
Copy link
Member Author

cheina97 commented Jun 1, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jun 2, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 5, 2023
@adamjensenbot adamjensenbot merged commit 4eab718 into liqotech:master Jun 5, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 5, 2023
@cheina97 cheina97 added the kind/feature New feature or request label Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
@cheina97 cheina97 deleted the frc/liqoctlWarning branch August 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisso frisso frisso approved these changes

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @adamjensenbot @frisso @aleoli