Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqonet: boringtun ARM fix #1852

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Liqonet: boringtun ARM fix #1852

merged 1 commit into from
Jun 8, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Jun 5, 2023 •
edited

Description

This PR changes the Docker image used to build boringtun-cli, since the old image is available only for AMD64.

This solves issue #1851

How Has This Been Tested?

  • On AWS EC2 AMI arch:x86_64kernel:4.14
  • On AWS EC2 AMI arch:arm64 kernel:4.14

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 linked an issue Jun 5, 2023 that may be closed by this pull request
liqo-gateway occurred ’/usr/bin/boringtun-cli: exec format error‘ when in aarch64 environment #1851
Closed
@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/build

@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/build

1 similar comment
@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/build

@cheina97 cheina97 marked this pull request as ready for review June 5, 2023 12:58
@cheina97
Copy link
Member Author

cheina97 commented Jun 5, 2023

/build

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jun 6, 2023
@cheina97
Copy link
Member Author

cheina97 commented Jun 6, 2023

/build

@cheina97
Copy link
Member Author

cheina97 commented Jun 6, 2023

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Jun 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@adamjensenbot adamjensenbot merged commit 88a7cc2 into liqotech:master Jun 8, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 8, 2023
@cheina97 cheina97 deleted the frc/boringtunarmfix branch June 8, 2023 08:28
@cheina97 cheina97 added the kind/feature New feature or request label Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
@cheina97 cheina97 mentioned this pull request Aug 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

liqo-gateway occurred ’/usr/bin/boringtun-cli: exec format error‘ when in aarch64 environment
3 participants
@cheina97 @adamjensenbot @aleoli