-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark local offloaded pods as NotReady when virtual-node is not ready (i.e. remote cluster failure) #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
fra98
force-pushed
the
frt/local-pod-status
branch
from
June 5, 2023 16:28
9c6b398
to
68268be
Compare
/test |
fra98
changed the title
Update local pods status in case of remote cluster failure
Mark local offloaded pods as NotReady when virtual-node is not ready (e.g., remote cluster failure)
Jun 8, 2023
fra98
changed the title
Mark local offloaded pods as NotReady when virtual-node is not ready (e.g., remote cluster failure)
Mark local offloaded pods as NotReady when virtual-node is not ready (i.e. remote cluster failure)
Jun 8, 2023
aleoli
reviewed
Jun 8, 2023
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller_test.go
Outdated
Show resolved
Hide resolved
fra98
force-pushed
the
frt/local-pod-status
branch
2 times, most recently
from
June 8, 2023 20:55
c9cf803
to
7b5f585
Compare
aleoli
approved these changes
Jun 9, 2023
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/podstatus-controller/podstatus_controller.go
Outdated
Show resolved
Hide resolved
fra98
force-pushed
the
frt/local-pod-status
branch
from
June 9, 2023 09:24
dcc50e7
to
14df8c1
Compare
/rebase test=true |
adamjensenbot
force-pushed
the
frt/local-pod-status
branch
from
June 9, 2023 09:26
14df8c1
to
2798c73
Compare
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Jun 9, 2023
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the virtual-kubelet logic to mark local offloaded pods as NotReady when the remote cluster has a failure (i.e., the liqo virtual node has the Ready condition set to False or Unknown).
In summary, it sets the Ready pod condition to False on all pods scheduled on a NotReady virtual node.
Implementation
local offloaded pods. The presence of the label indicates that the status of the offloaded pod can be managed/updated by the local cluster and can't currently be reflected/updated from the remote cluster (likely due to a remote cluster failure).
Motivation
We mark pods as NotReady because the Kubernetes node controller skips this update (likely due to a bug). This is necessary to prevent services redirecting traffic to not ready pods (since the endpointslice controller keeps in sync the endpointslice Ready condition with the associated pod Ready condition).
How Has This Been Tested?