Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to set images to use during volumes move #1878

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add flag to set images to use during volumes move #1878

merged 1 commit into from
Jun 28, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jun 23, 2023

Description

This pr adds two new flags to specify the image to use to move volumes between clusters

How Has This Been Tested?

  • e2e test

@aleoli aleoli added the kind/feature New feature or request label Jun 23, 2023
@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Jun 23, 2023

/test

1 similar comment
@aleoli
Copy link
Member Author

aleoli commented Jun 27, 2023

/test

@aleoli aleoli marked this pull request as ready for review June 27, 2023 08:35
@aleoli aleoli requested review from cheina97 and fra98 June 27, 2023 08:36
@aleoli
Copy link
Member Author

aleoli commented Jun 28, 2023

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Jun 28, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 28, 2023
@adamjensenbot adamjensenbot merged commit d7625e2 into liqotech:master Jun 28, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 28, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleoli @adamjensenbot @fra98