Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to "liqoctl status peer" status and URL of the remote API server #1880

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Add to "liqoctl status peer" status and URL of the remote API server #1880

merged 1 commit into from
Jul 4, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Jun 27, 2023 •
edited

Description

This PR adds to "liqoctl status peer" the status and the URL of the remote API server.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Locally
  • Unit tests
  • E2E tests

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/feature New feature or request label Jun 27, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 28, 2023
@fra98 fra98 marked this pull request as ready for review June 28, 2023 08:46
@fra98 fra98 requested review from cheina97 and aleoli June 28, 2023 08:46
@aleoli
Copy link
Member

aleoli commented Jul 3, 2023

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented Jul 3, 2023

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Jul 4, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 4, 2023
@adamjensenbot adamjensenbot merged commit 82b3303 into liqotech:master Jul 4, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 4, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fra98 @adamjensenbot @aleoli