Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: increased restart count tollerance #1892

Merged
merged 1 commit into from
Jul 3, 2023
Merged

E2E tests: increased restart count tollerance #1892

merged 1 commit into from
Jul 3, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Jul 3, 2023 •
edited

Description

This PR increases the restart tolerance in E2E tests.

How Has This Been Tested?

  • E2E tests

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Jul 3, 2023

/rebase test=true

@cheina97 cheina97 requested review from aleoli and fra98 July 3, 2023 14:13
@aleoli
Copy link
Member

aleoli commented Jul 3, 2023

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Jul 3, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 3, 2023
@adamjensenbot adamjensenbot merged commit 2a13fb4 into liqotech:master Jul 3, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 3, 2023
@cheina97 cheina97 added kind/cleanup Refactoring code github_actions Pull requests that update GitHub Actions code and removed kind/cleanup Refactoring code labels Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
@cheina97 cheina97 deleted the frc/e2erestart branch August 16, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @adamjensenbot @aleoli @fra98