Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liqoctl: add create VirtualNode command #1944

Merged
merged 1 commit into from
Aug 31, 2023
Merged

liqoctl: add create VirtualNode command #1944

merged 1 commit into from
Aug 31, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Aug 7, 2023 •
edited

Description

This pr adds a new command to liqoctl to manage (create and delete) VirtualNodes

How Has This Been Tested?

  • yaml generation, using the -o yaml flag
  • directly creating a second vn for an established peering

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/liqoctl-create-vn branch 3 times, most recently from f01efc2 to a79b7f1 Compare August 8, 2023 15:26
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 8, 2023
@aleoli aleoli force-pushed the aol/liqoctl-create-vn branch 5 times, most recently from 9869d44 to e285383 Compare August 25, 2023 12:49
@aleoli
Copy link
Member Author

aleoli commented Aug 25, 2023

/test

@aleoli aleoli marked this pull request as ready for review August 25, 2023 12:56
@aleoli aleoli requested a review from cheina97 August 25, 2023 12:56
@cheina97
Copy link
Member

Last comment about files hierarchy. Could be a good idea moving virtualnode folder inside rest? I think it would be more tidy.

@cheina97
Copy link
Member

/rebase test=true

@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 31, 2023
@adamjensenbot adamjensenbot merged commit f217d0f into liqotech:master Aug 31, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 31, 2023
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleoli @adamjensenbot @cheina97