Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liqo-route: added static mac to vxlan + device sanity check #1945

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Aug 8, 2023

Description

This PR adds a static mac address to the liqo-vxlan interface.
This solves an issue with virtualized Ubunutu2204 ( and maybe other distributions... ), where the MAC address I overwritten by the operating system immediately after it has been auto-generated by the operating system itself.

It introduces also a simple sanity check on vxlan interface configuration, which restart the pod in case of troubles.

How Has This Been Tested?

  • KinD (Debian 11)
  • CAPK (Ubuntu 2004)
  • CAPK (Ubuntu 2204)
  • OpenShift
  • EKS
  • GKE
  • AKS

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Aug 8, 2023

/build

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 8, 2023
@cheina97 cheina97 added the kind/bug Something isn't working label Aug 9, 2023
@cheina97
Copy link
Member Author

cheina97 commented Aug 9, 2023

/build

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 9, 2023
@cheina97 cheina97 force-pushed the frc/vxlanfix branch 2 times, most recently from 5801531 to b13bd9b Compare August 9, 2023 09:28
@cheina97 cheina97 changed the title Liqo-route: added static mac to vxlan Liqo-route: added static mac to vxlan + device sanity check Aug 9, 2023
@cheina97 cheina97 marked this pull request as draft August 9, 2023 09:30
@cheina97
Copy link
Member Author

cheina97 commented Aug 9, 2023

/rebase test=true

@cheina97 cheina97 force-pushed the frc/vxlanfix branch 2 times, most recently from d88347d to 6b31e62 Compare August 9, 2023 12:08
@cheina97
Copy link
Member Author

cheina97 commented Aug 9, 2023

/build

@cheina97 cheina97 marked this pull request as ready for review August 9, 2023 13:59
@cheina97
Copy link
Member Author

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Aug 16, 2023

/test

@aleoli
Copy link
Member

aleoli commented Aug 16, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 16, 2023
@adamjensenbot adamjensenbot merged commit baa4a2e into liqotech:master Aug 16, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 16, 2023
@cheina97 cheina97 deleted the frc/vxlanfix branch August 16, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants