AllowList-based and DenyList-based Resource Reflection #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
fra98
force-pushed
the
frt/allow-deny-refl
branch
from
61b8052
to
da1f975
Compare
|
One of the most useful feature for us. Looking forward to test it out. Thanks |
fra98
force-pushed
the
frt/allow-deny-refl
branch
2 times, most recently
from
2810e62
to
bdf7d48
Compare
|
/hold |
|
/test |
aleoli
reviewed
Aug 31, 2023
fra98
force-pushed
the
frt/allow-deny-refl
branch
from
64cd0ef
to
89a9652
Compare
aleoli
approved these changes
Sep 4, 2023
fra98
force-pushed
the
frt/allow-deny-refl
branch
2 times, most recently
from
0ae5e8c
to
219f575
Compare
|
/test |
fra98
force-pushed
the
frt/allow-deny-refl
branch
from
219f575
to
56336ff
Compare
|
/test |
|
/unhold |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the possibility to configure a per-resource whitelist-based reflection mechanism.
Two different reflection mechanisms can be selected at install time:
liqo.io/skip-reflectionannotation.liqo.io/allow-reflectionannotation.You can configure the preferred reflection mechanism for each resource type through the Helm value
reflection.<resource>.type.DenyList is the default reflection policy for all resources (services, endpointslices, ingresses, configmaps, secrets, events).
Note: the pods, PVCs, and serviceaccounts reflectors follow a custom Liqo logic and can't be customized.
Fixes #1855
In addition:
reflection.<resource>.workers. Set 0 to disable the reflection completely.How Has This Been Tested?