Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS vnet resource group #1969

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

scottboring
Copy link
Contributor

Adding optional flag for vnet resource group for scenarios when the vnet is in a different resource group from the AKS resource

Description

The virtual network is not always in the same resource group as the AKS resource and subsequently this needs to be exposed as a param to the CLI

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Executed CLI using param and verified param was used
  • Executed CLI without param and verified param defaulted to resource-group-name

@adamjensenbot
Copy link
Collaborator

Hi @scottboring. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member

/rebase test=true

…net is in a different resource group from the AKS resource
Copy link
Member

@aleoli aleoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scottboring! Thanks for your contribution!

@aleoli
Copy link
Member

aleoli commented Aug 25, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 25, 2023
@adamjensenbot adamjensenbot merged commit 94c73c0 into liqotech:master Aug 25, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants