Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: FAQ page #1976

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Docs: FAQ page #1976

merged 1 commit into from
Jan 11, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 1, 2023

Description

This PR adds to the documentation a FAQ page.

This is still a work in progress. Feel free to suggest new questions to add to the PR.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Sep 1, 2023

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Sep 1, 2023
@cheina97 cheina97 added the kind/docs Improvements or additions to documentation label Oct 5, 2023
@fra98 fra98 force-pushed the frt/faq-docs branch 2 times, most recently from 11ce17e to cf0e525 Compare December 28, 2023 17:07
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 28, 2023
@fra98
Copy link
Member Author

fra98 commented Dec 29, 2023

/unhold

@fra98 fra98 marked this pull request as ready for review December 29, 2023 10:08
@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Dec 29, 2023
@fra98 fra98 requested a review from aleoli December 29, 2023 10:20
@fra98 fra98 requested a review from cheina97 January 3, 2024 12:53
aleoli
aleoli approved these changes Jan 9, 2024
View reviewed changes
docs/faq/faq.md Outdated Show resolved Hide resolved
@fra98
Copy link
Member Author

fra98 commented Jan 11, 2024

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented Jan 11, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 11, 2024
@adamjensenbot adamjensenbot merged commit e273ed5 into liqotech:master Jan 11, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 11, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
kind/docs Improvements or additions to documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fra98 @adamjensenbot @aleoli @cheina97