Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: chunks slice loop append replace #1986

Merged
merged 1 commit into from
Sep 8, 2023
Merged

chore: chunks slice loop append replace #1986

merged 1 commit into from
Sep 8, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Sep 7, 2023

Description

chunks slice loop append replace.

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

@adamjensenbot
Copy link
Collaborator

Hi @testwill. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member

aleoli commented Sep 7, 2023

Hi @testwill! Thanks for your contribution! Can you please set a title that describes the PR content and a short description? The PR looks good to me.

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill testwill changed the title chore: import packages only once chore: chunks slice loop append replace Sep 8, 2023
@aleoli
Copy link
Member

aleoli commented Sep 8, 2023

/test

@aleoli
Copy link
Member

aleoli commented Sep 8, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@adamjensenbot adamjensenbot merged commit da097c7 into liqotech:master Sep 8, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 8, 2023
@testwill testwill deleted the slice branch September 8, 2023 09:30
@aleoli aleoli added the kind/cleanup Refactoring code label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants