Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force NodePort's port from Helm Values #2037

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Force NodePort's port from Helm Values #2037

merged 1 commit into from
Sep 22, 2023

Conversation

cheina97
Copy link
Member

Description

This PR adds the possibility to override the port used by Liqo NodePort services.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/forcenodeport branch 3 times, most recently from 3ab572d to d1e55fa Compare September 21, 2023 11:04
@cheina97 cheina97 marked this pull request as ready for review September 21, 2023 11:04
@cheina97
Copy link
Member Author

@Sharathmk99, we are refactoring a part of helm chart modified by you.

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 22, 2023
@adamjensenbot adamjensenbot merged commit 722bdd3 into liqotech:master Sep 22, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 22, 2023
@cheina97 cheina97 added the kind/feature New feature or request label Oct 31, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @aleoli