Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer deference in pod Ready condition #2039

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix nil pointer deference in pod Ready condition #2039

merged 1 commit into from
Sep 25, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Sep 21, 2023

Description

This PR fixes a nil pointer dereference error occurring in the virtual kubelet when a local offloaded pod does not have the Ready condition set.

Fixes #2038

@fra98 fra98 added the kind/bug Something isn't working label Sep 21, 2023
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 mentioned this pull request Sep 21, 2023
Closed
@fra98
Copy link
Member Author

fra98 commented Sep 21, 2023

/test

@fra98 fra98 requested a review from aleoli September 21, 2023 14:56
aleoli
aleoli approved these changes Sep 21, 2023
View reviewed changes
pkg/virtualKubelet/reflection/workload/podns.go Outdated Show resolved Hide resolved
@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/test

@fra98
Copy link
Member Author

fra98 commented Sep 25, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 25, 2023
@adamjensenbot adamjensenbot merged commit 5278146 into liqotech:master Sep 25, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 25, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual Kubelet - invalid memory address
4 participants
@fra98 @adamjensenbot @cheina97 @aleoli