Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric Agent: cache fix #2080

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Metric Agent: cache fix #2080

merged 1 commit into from
Oct 17, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 12, 2023 •
edited

Description

This PR fixes the cache used in liqo-metric-agent.

How Has This Been Tested?

  • Locally on KinD

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/build

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 12, 2023
@cheina97
Copy link
Member Author

/build

@cheina97 cheina97 force-pushed the frc/metricsagent branch 2 times, most recently from 2183d61 to 6b214a0 Compare October 13, 2023 08:08
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 13, 2023
@cheina97 cheina97 force-pushed the frc/metricsagent branch 2 times, most recently from 415bf79 to c619d31 Compare October 13, 2023 08:40
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 13, 2023
@cheina97 cheina97 force-pushed the frc/metricsagent branch 3 times, most recently from 0cfef0a to 5608a85 Compare October 13, 2023 10:42
@cheina97 cheina97 marked this pull request as ready for review October 13, 2023 10:44
@cheina97
Copy link
Member Author

/test

aleoli
aleoli approved these changes Oct 16, 2023
View reviewed changes
deployments/liqo/templates/liqo-metric-agent-deployment.yaml Outdated Show resolved Hide resolved
pkg/utils/clients/get_cached_client.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 17, 2023
@adamjensenbot adamjensenbot merged commit 95d49b2 into liqotech:master Oct 17, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 17, 2023
@aleoli aleoli added the kind/bug Something isn't working label Oct 24, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
@cheina97 cheina97 deleted the frc/metricsagent branch November 2, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli Awaiting requested review from aleoli

@alessandrofavale alessandrofavale Awaiting requested review from alessandrofavale

Assignees
No one assigned
Labels
kind/bug Something isn't working size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @adamjensenbot @aleoli @alessandrofavale