Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liqonet: IPSet #2109

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Liqonet: IPSet #2109

merged 1 commit into from
Oct 24, 2023

Conversation

cheina97
Copy link
Member

Description

This PR adds the https://pkg.go.dev/k8s.io/kubernetes/pkg/util/ipset inside the liqo repository since it is not included anymore in the new kubernetes package release.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

Copy link
Member

@aleoli aleoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the import in order to use this package

@cheina97 cheina97 force-pushed the frc/ipset branch 2 times, most recently from 506378c to c370d61 Compare October 24, 2023 07:31
@cheina97
Copy link
Member Author

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Oct 24, 2023

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Oct 24, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 24, 2023
@adamjensenbot adamjensenbot merged commit c6b63a1 into liqotech:master Oct 24, 2023
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 24, 2023
@aleoli aleoli added the kind/cleanup Refactoring code label Oct 24, 2023
@cheina97 cheina97 deleted the frc/ipset branch October 24, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants