Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pre-commit hook configuration #2117

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Added pre-commit hook configuration #2117

merged 1 commit into from
Oct 31, 2023

Conversation

cheina97
Copy link
Member

This PR adds the configuration file for pre-commit

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 requested review from fra98 and aleoli October 30, 2023 11:52
@cheina97
Copy link
Member Author

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Oct 31, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 31, 2023
@adamjensenbot adamjensenbot merged commit 306ba33 into liqotech:master Oct 31, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 31, 2023
@cheina97 cheina97 deleted the frc/precommit branch October 31, 2023 10:19
@cheina97 cheina97 added the kind/cleanup Refactoring code label Oct 31, 2023
@p-linnane p-linnane mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/cleanup Refactoring code size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @aleoli