Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqonet: connchecker latency fix #2120

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Liqonet: connchecker latency fix #2120

merged 1 commit into from
Nov 3, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Nov 2, 2023

Description

This PR fixes a bug with connchecker and latency.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 requested review from aleoli and fra98 November 2, 2023 15:07
@cheina97
Copy link
Member Author

cheina97 commented Nov 3, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Nov 3, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 3, 2023
@adamjensenbot adamjensenbot merged commit 9e2a5df into liqotech:master Nov 3, 2023
12 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 3, 2023
@cheina97 cheina97 deleted the frc/conncheckfix branch November 3, 2023 20:47
@p-linnane p-linnane mentioned this pull request Nov 8, 2023
Merged
@cheina97 cheina97 added the kind/bug Something isn't working label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@aleoli aleoli Awaiting requested review from aleoli

Assignees
No one assigned
Labels
kind/bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @fra98