Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Helm Lint #2180

Merged
merged 1 commit into from
Dec 1, 2023
Merged

CI: Helm Lint #2180

merged 1 commit into from
Dec 1, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 1, 2023 •
edited

Description

This PR adds the helm lint action in the linting workflow

This PR fixes also some linter errors and add the icon to the helm chart

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/helmlint branch 6 times, most recently from 95b87bc to 9d4af22 Compare December 1, 2023 09:29
@cheina97
Copy link
Member Author

cheina97 commented Dec 1, 2023

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Dec 1, 2023
@cheina97
Copy link
Member Author

cheina97 commented Dec 1, 2023

/unhold

@cheina97 cheina97 added kind/cleanup Refactoring code github_actions Pull requests that update GitHub Actions code labels Dec 1, 2023
@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Dec 1, 2023
@cheina97
Copy link
Member Author

cheina97 commented Dec 1, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Dec 1, 2023

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Dec 1, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 1, 2023
@adamjensenbot adamjensenbot merged commit 9fb003e into liqotech:master Dec 1, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 1, 2023
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code kind/cleanup Refactoring code size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @fra98