Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: added nilaway (static analysis tool to detect potential Nil panics in Go code) #2255

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Dec 29, 2023

Description

This PR adds to the Makefile a command to run nilaway, a static analysis tool to detect potential Nil panics in Go code.
Issue make staticcheck to run the tool.

Note: the project is still under active development so false positives can happen.

@fra98 fra98 added the kind/feature New feature or request label Dec 29, 2023
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member

cheina97 commented Jan 3, 2024

/rebase test=true

@cheina97
Copy link
Member

cheina97 commented Jan 3, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 3, 2024
@adamjensenbot adamjensenbot merged commit 4456cf7 into liqotech:master Jan 3, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 3, 2024
@fra98 fra98 deleted the frt/nilaway-makefile branch January 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants