Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add net interfaces monitoring #2259

Merged
merged 1 commit into from
Jan 16, 2024
Merged

add net interfaces monitoring #2259

merged 1 commit into from
Jan 16, 2024

Conversation

pucciorenzo
Copy link
Contributor

@pucciorenzo pucciorenzo commented Jan 8, 2024 •
edited

Description

This package includes a tool to monitor network interfaces changes and send a channel with a generic event whenever a change happens. It can detect:

  • Added/Removed interface
  • Interface set to up/down
  • Added/Removed IP address to/from an interface
  • Added/Removed route to/from an interface's routing table

How Has This Been Tested?

Manually, adding/removing interfaces, IP addresses, routes

@adamjensenbot
Copy link
Collaborator

Hi @pucciorenzo. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 added the kind/feature New feature or request label Jan 9, 2024
@pucciorenzo pucciorenzo marked this pull request as ready for review January 12, 2024 08:15
aleoli
aleoli reviewed Jan 15, 2024
View reviewed changes
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
aleoli
aleoli reviewed Jan 15, 2024
View reviewed changes
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

@cheina97, do you want to review it, too?

@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Jan 16, 2024
cheina97
cheina97 approved these changes Jan 16, 2024
View reviewed changes
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
pkg/utils/netmonitor/netmonitor.go Outdated Show resolved Hide resolved
@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

@pucciorenzo, it looks good. Can you please squash your commits?

@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Jan 16, 2024
@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Jan 16, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 16, 2024
@adamjensenbot adamjensenbot merged commit 62241a3 into liqotech:master Jan 16, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 16, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pucciorenzo @adamjensenbot @aleoli @cheina97