Helm: Fix extraArgs #2288
Merged
Helm: Fix extraArgs #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kariya-mitsuru. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
Hi @kariya-mitsuru, thanks for your contribution. In other components we use this syntax to add extraargs https://github.com/kariya-mitsuru/liqo/blob/a3748d493921bc07262461d7277a21fd5d9e633c/deployments/liqo/templates/liqo-crd-replicator-deployment.yaml#L39-L41. Can you adapt your commit to our syntax or modify all the other components? |
fra98
reviewed
Jan 18, 2024
kariya-mitsuru
force-pushed
the
fix-extraArgs
branch
from
721e5b2
to
a5340da
Compare
|
LGTM! 👍🏻 @kariya-mitsuru |
ExtraArgs was not applied in the following two deployments and one cronjob, so fixed it so that it is applied correctly. - deployments/liqo/templates/liqo-metric-agent-deployment.yaml - deployments/liqo/templates/liqo-proxy-deployment.yaml - deployments/liqo/templates/liqo-telemetry-cronjob.yaml
kariya-mitsuru
force-pushed
the
fix-extraArgs
branch
from
29aca63
to
e95a162
Compare
|
/rebase test=true |
fra98
approved these changes
Jan 19, 2024
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExtraArgs was not applied in the following two deployments and one cronjob, so fixed it so that it is applied correctly.