Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liqoctl: get liqo version from controller-manager #2289

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Jan 18, 2024

Description

This PR includes the following changes:

  • adds a utility function to get the installed Liqo version (without using Helm client)
  • use the new function in liqoctl version command
  • added Liqo version in liqoctl status command

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/version branch 3 times, most recently from b9ff13e to 5182f92 Compare January 19, 2024 14:37
@fra98 fra98 requested review from cheina97 and aleoli January 19, 2024 14:44
@fra98
Copy link
Member Author

fra98 commented Jan 22, 2024

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented Jan 22, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 22, 2024
@adamjensenbot adamjensenbot merged commit 740be94 into liqotech:master Jan 22, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 22, 2024
@fra98 fra98 added the kind/cleanup Refactoring code label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants