Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liqoctl install on AzureCNI #2295

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix liqoctl install on AzureCNI #2295

merged 1 commit into from
Mar 4, 2024

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jan 23, 2024 •
edited

Description

This pr fixes the Liqo installation on AzureCNI clusters

How Has This Been Tested?

  • on Azure

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Jan 23, 2024

/test

@fra98 fra98 added the kind/bug Something isn't working label Jan 30, 2024
@aleoli aleoli force-pushed the aol/fix-azure-cni branch 2 times, most recently from 93ffeed to b98132d Compare March 1, 2024 09:31
@aleoli
Copy link
Member Author

aleoli commented Mar 1, 2024

/test

@aleoli aleoli marked this pull request as ready for review March 1, 2024 09:41
@aleoli aleoli requested review from cheina97 and fra98 March 1, 2024 09:42
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 1, 2024
@aleoli
Copy link
Member Author

aleoli commented Mar 1, 2024

/test

@fra98
Copy link
Member

fra98 commented Mar 4, 2024

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Mar 4, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 4, 2024
@adamjensenbot adamjensenbot merged commit 403acfa into liqotech:master Mar 4, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 4, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
kind/bug Something isn't working size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleoli @adamjensenbot @fra98