-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select remote namespace name when offloading #2310
Merged
adamjensenbot
merged 1 commit into
liqotech:master
from
aleoli:aol/selecte-remote-ns-name
Feb 5, 2024
Merged
Select remote namespace name when offloading #2310
adamjensenbot
merged 1 commit into
liqotech:master
from
aleoli:aol/selecte-remote-ns-name
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @aleoli. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
/build |
aleoli
force-pushed
the
aol/selecte-remote-ns-name
branch
from
January 30, 2024 14:44
b911cdc
to
eed51a5
Compare
aleoli
force-pushed
the
aol/selecte-remote-ns-name
branch
3 times, most recently
from
January 30, 2024 14:53
3268ab1
to
f7481ff
Compare
/test |
fra98
approved these changes
Jan 30, 2024
aleoli
force-pushed
the
aol/selecte-remote-ns-name
branch
from
February 5, 2024 10:14
f7481ff
to
0d52288
Compare
/test |
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Feb 5, 2024
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows selecting the name a namespace will assume in the other cluster after offloading.
Fixes #2307
How Has This Been Tested?