Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select remote namespace name when offloading #2310

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jan 30, 2024

Description

This PR allows selecting the name a namespace will assume in the other cluster after offloading.

Fixes #2307

How Has This Been Tested?

  • locally

@aleoli aleoli added kind/feature New feature or request and removed size/M labels Jan 30, 2024
@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Jan 30, 2024

/build

@aleoli aleoli force-pushed the aol/selecte-remote-ns-name branch 3 times, most recently from 3268ab1 to f7481ff Compare January 30, 2024 14:53
@aleoli
Copy link
Member Author

aleoli commented Jan 30, 2024

/test

@aleoli aleoli marked this pull request as ready for review January 30, 2024 14:54
@aleoli aleoli requested review from cheina97 and fra98 January 30, 2024 14:54
docs/usage/namespace-offloading.md Outdated Show resolved Hide resolved
@aleoli
Copy link
Member Author

aleoli commented Feb 5, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Feb 5, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
@adamjensenbot adamjensenbot merged commit 209cb75 into liqotech:master Feb 5, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow setting the name of the remote namespaces
3 participants