Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Node: specify labels/annotations not reflected in API Spec #2311

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Virtual Node: specify labels/annotations not reflected in API Spec #2311

merged 1 commit into from
Feb 5, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Jan 30, 2024

Description

This PR moves the labels/annots not reflected from the VK deployment to the VirtualNode Spec API.

How Has This Been Tested?

  • Locally
  • Unit
  • e2e

@fra98 fra98 added the kind/feature New feature or request label Jan 30, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Jan 30, 2024

/test

@fra98 fra98 requested a review from aleoli January 30, 2024 16:28
@fra98
Copy link
Member Author

fra98 commented Feb 1, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/rebase test=true

@fra98
Copy link
Member Author

fra98 commented Feb 5, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
@adamjensenbot adamjensenbot merged commit 9e7fc87 into liqotech:master Feb 5, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Feb 5, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fra98 @adamjensenbot @aleoli