Support priorityClassName in Helm chart #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EladDolev. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
Hi @EladDolev, thanks for your contribution. It seems like a useful feature. Btw, keep in mind that the |
fra98
requested changes
Feb 27, 2024
|
Done as requested @fra98 |
fra98
approved these changes
Feb 29, 2024
|
LGTM! |
EladDolev
force-pushed
the
priority_class
branch
from
2996bc4
to
dca21ef
Compare
|
Done @fra98 |
|
/rebase test=true |
|
/rebase |
Signed-off-by: Elad Dolev <dolevelad@gmail.com>
adamjensenbot
force-pushed
the
priority_class
branch
from
dca21ef
to
281d3eb
Compare
|
/test |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for defining priorityClassName on some of the pods
It is especially useful for the
liqo-routeas in real case scenarios it is not being schedule to some of the worker nodes and it breaks the network for anything which is running there. When assigning a high (enough) priority toliqo-routeit is always scheduled to all of the worker nodesHow Has This Been Tested?
Installed with default values -> no priorityClassName exists on any of the pods
Assigned priorityClassName values to all relevant workloads and the workloads are running with priorityClassName