Add Prometheus scraping in Helm chart #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EladDolev. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
I'm happy to change the CRD Replicator PodMonitor to ServiceMonitor if requested 😄 |
|
/rebase test=true |
adamjensenbot
force-pushed
the
improve_scraping
branch
from
b7f7eae
to
4b12bf5
Compare
|
/rebase test=true |
* Controller Manager * CRD Replicator Signed-off-by: Elad Dolev <dolevelad@gmail.com>
adamjensenbot
force-pushed
the
improve_scraping
branch
from
4b12bf5
to
c8e7ea4
Compare
aleoli
approved these changes
Mar 1, 2024
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding scraping using ServiceMonitor to the Controller Manager and PodMonitor to the CRD Replicator
Motivation is having the ability to scrape the controllers metrics in order of creating alerts on failed reconciles etc.
How Has This Been Tested?
Installed with default values -> only change is the addition of the
metricsport on the relevant Deployment(s)Installed with relevant PodMonitor/ServiceMonitor enabled -> metrics are visible in Prometheus