Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ServiceMonitor PodMonitor scrape config null values #2374

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

shkrid
Copy link
Contributor

@shkrid shkrid commented Mar 5, 2024

Description

When using liqo's ServiceMonitors and PodMonitors with ArgoCD we encounter unresolvable diff with null values.
ArgoCD failed to sync this resources.

How Has This Been Tested?

Deployed new version -> ArgoCD does not show wrong diff.

image

@adamjensenbot
Copy link
Collaborator

Hi @shkrid. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member

aleoli commented Mar 8, 2024

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Mar 8, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 8, 2024
@adamjensenbot adamjensenbot merged commit 7cbb865 into liqotech:master Mar 8, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants