-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support getting aws credentials from existing secret instead of clear text in values file #2395
Conversation
Hi @dennispan. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
@aleoli Thanks for taking an initial look. Do you mind taking another look? |
/test |
Thanks @dennispan! It looks good to me! |
/rebase test=true |
Noticed now, can you please squash your commits to one? |
@aleoli Thank you! I've squashed and rebased the commits. BTW, what is the release process of the helm charts? |
/rebase test=true |
… text in values file
The helm charts are released with the liqo releases. |
/merge |
Description
The changes add support in the Helm chart to use an existing secret for AWS credentials, instead of having the secrets as clear texts in values file
Fixes #(issue)
How Has This Been Tested?
Tested with