Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting aws credentials from existing secret instead of clear text in values file #2395

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

dennispan
Copy link
Contributor

Description

The changes add support in the Helm chart to use an existing secret for AWS credentials, instead of having the secrets as clear texts in values file

Fixes #(issue)

How Has This Been Tested?

Tested with

helm template liqo deployments/liqo --version HEAD -f <values-file-path> --namespace liqo

@adamjensenbot
Copy link
Collaborator

Hi @dennispan. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@dennispan
Copy link
Contributor Author

@aleoli Thanks for taking an initial look. Do you mind taking another look?

@aleoli
Copy link
Member

aleoli commented Mar 20, 2024

/test

@aleoli
Copy link
Member

aleoli commented Mar 20, 2024

Thanks @dennispan! It looks good to me!

@aleoli
Copy link
Member

aleoli commented Mar 20, 2024

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Mar 20, 2024

Noticed now, can you please squash your commits to one?

@aleoli aleoli added the hold Prevent bot merging label Mar 20, 2024
@dennispan
Copy link
Contributor Author

@aleoli Thank you! I've squashed and rebased the commits. BTW, what is the release process of the helm charts?

@aleoli
Copy link
Member

aleoli commented Mar 21, 2024

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Mar 21, 2024

The helm charts are released with the liqo releases.
If you want to use a not-yet-released helm chart you can install it by using the local-chart-path flag of liqoctl.

@aleoli aleoli removed the hold Prevent bot merging label Mar 21, 2024
@aleoli
Copy link
Member

aleoli commented Mar 21, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 21, 2024
@adamjensenbot adamjensenbot merged commit cda502e into liqotech:master Mar 21, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 21, 2024
@dennispan dennispan deleted the helm-aws branch March 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants