Improve Advertisement Generation and Broadcasting #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 22, 2020
palexster
reviewed
Sep 22, 2020
| used by the k8s cluster like the podCIDR and ClusterCIDR | ||
| description: this field is used by the IPAM embedded in the tunnelEndpointCreator | ||
| if the podCIDR of a peering cluster needs to be NATed a new subnet | ||
| from the 10.0.0.0/8 is used. if subnets belonging to that range |
There was a problem hiding this comment.
The sentence starting with if is a bit hard to understand.
A possible proposal:
Reserved subnets listed in this field are excluded from the list of possible subnets used for natting POD CIDR. Add here the subnets already used in your environment.
There was a problem hiding this comment.
@alacuku can you check if the new description of this field is ok? thanks!
fraborg
force-pushed
the
frb/broadcaster-upgrade
branch
from
2304eb2
to
382886f
Compare
palexster
changed the title
fraborg
force-pushed
the
frb/broadcaster-upgrade
branch
from
382886f
to
2566c0f
Compare
Pull Request Test Coverage Report for Build 266973768
💛 - Coveralls |
2 tasks
|
Ref. #281 Unlinking because this PR does not address this issue completely. |
2 tasks
fraborg
force-pushed
the
frb/broadcaster-upgrade
branch
from
2566c0f
to
44cea37
Compare
palexster
approved these changes
Sep 22, 2020
|
/rebase |
- use an intermediate map to avoid duplicate images - added Prefix const to avoid hardcoded names for resources
|
Rebase status: success! |
adamjensenbot
force-pushed
the
frb/broadcaster-upgrade
branch
from
44cea37
to
0ac9ee8
Compare
AbakusW
approved these changes
Sep 23, 2020
|
/rebase |
|
Rebase status: success! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR
PeeringRequestwith the status of theAdvertisement.Advertisementfiltering images with the same nameMinor changes
How Has This Been Tested?
PeeringRequestis correctly updated