Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Advertisement print columns #428

Merged
merged 1 commit into from Dec 21, 2020
Merged

Added Advertisement print columns #428

merged 1 commit into from Dec 21, 2020

Conversation

fraborg
Copy link
Member

@fraborg fraborg commented Dec 21, 2020

Hi guys!! 馃巻 馃巻

A very small PR after a lot of time 馃槃

Description

Kubebuilder allows to specify additional print columns when you perform kubectl get <crd>( link )
In this PR some additional columns have been added to the Advertisement to easily find its status (Accepted/Refused), expiration date and if the VirtualKubelet has been created. Different/other fields can be easily added.
A dead link to Contributing page has been updated too.

How Has This Been Tested?

Tested with our beloved KinD

Fixed dead link in contributing
@adamjensenbot
Copy link
Collaborator

Hi @fraborg. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 馃挜 Breaking Change
  • kind/feature: 馃殌 New Feature
  • kind/bug: 馃悰 Bug Fix
  • kind/cleanup: 馃Ч Code Refactoring
  • kind/docs: 馃摑 Documentation

Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @fraborg! Thanks for this PR 馃榾 your contribution is always warmly welcome!

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 21, 2020
@adamjensenbot adamjensenbot merged commit cb6f4d0 into master Dec 21, 2020
@adamjensenbot adamjensenbot deleted the frb/adv-print branch December 21, 2020 14:50
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants