Fixed changePodIp func #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidefalcone1. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/ok-to-test |
|
Hi @davidefalcone1. Thanks for your PR! I'm waiting for a Liqo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test. Once the patch is verified, the new status will be reflected by the ok-to-test label. |
davidefalcone1
force-pushed
the
dfa/fix
branch
7 times, most recently
from
a31588d
to
cd8f9cf
Compare
|
/rebase |
palexster
reviewed
Apr 13, 2021
| newPodIpBuilder.WriteString(s) | ||
| newPodIpBuilder.WriteString(".") | ||
| } | ||
| // Parse newPodCidr |
There was a problem hiding this comment.
The following logic may deserve to be in a separate function
alacuku
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function changePodIp forges a new IP taking the first 2 octets from the newPodCidr and the last 2 from the original Pod Ip. Since Liqo does support networks with random masks, this function needs to be modified: thanks to this PR, the function now takes a number of bits equal to the mask length from the newPodCidr and 32-mask bits from the old Pod IP.