Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition for overlay-operator tests. #683

Merged
merged 1 commit into from Jun 15, 2021

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jun 15, 2021

Description

This PR fixes unit tests of the overlay-operator. Some times objects updated on the testing api server are not immediately ready. Causing some functions to retrieve old versions of the objects and causing the tests to fail.

@adamjensenbot
Copy link
Collaborator

Hi @alacuku. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@alacuku
Copy link
Member Author

alacuku commented Jun 15, 2021

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 15, 2021
@adamjensenbot adamjensenbot merged commit 6515fc5 into master Jun 15, 2021
@adamjensenbot adamjensenbot deleted the kcl/overlay-operator-test-fix branch June 15, 2021 15:58
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants