Resources Phase Explicit Signaling #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aleoli. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
aleoli
force-pushed
the
aol/explicit-signaling
branch
from
1f90e60
to
b1a3986
Compare
aleoli
changed the title
aleoli
changed the title
aleoli
force-pushed
the
aol/explicit-signaling
branch
from
b1a3986
to
e6b36b7
Compare
aleoli
changed the title
aleoli
changed the title
aleoli
force-pushed
the
aol/explicit-signaling
branch
from
e6b36b7
to
c9f4198
Compare
aleoli
force-pushed
the
aol/explicit-signaling
branch
from
eced38e
to
24f23f2
Compare
aleoli
changed the title
palexster
reviewed
Jul 5, 2021
internal/discovery/foreign-cluster-operator/foreign-cluster-controller.go
Show resolved
Hide resolved
palexster
reviewed
Jul 5, 2021
pkg/liqo-controller-manager/resourceoffer-controller/resourceoffer_controller_methods.go
Show resolved
Hide resolved
aleoli
force-pushed
the
aol/explicit-signaling
branch
2 times, most recently
from
4a21841
to
9f6054e
Compare
palexster
approved these changes
Jul 5, 2021
giorio94
approved these changes
Jul 5, 2021
pkg/liqo-controller-manager/resourceoffer-controller/resourceoffer_controller_methods.go
Outdated
Show resolved
Hide resolved
allows peering-related resources (i.e. ResourceRequest and ResourceOffers) to have an explicit mechanism to indicate the desired state (Create os Delete) handled by the home cluster, and the observed state (Created od Deleted) handled by the remote cluster. In this way, we are able the handle a graceful deletion of these resources and to have a graceful peering tear down. The VirtualKublet can now have the time required for a completed clean-up of the remote cluster.
aleoli
force-pushed
the
aol/explicit-signaling
branch
from
9f6054e
to
1c9f792
Compare
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr allows peering-related resources (i.e. ResourceRequest and ResourceOffers) to have an explicit mechanism to indicate the desired state (Create os Delete) handled by the home cluster (in the resource
Spec), and the observed state (Created od Deleted) handled by the remote cluster (in the resourceStatus). In this way, we are able the handle a graceful deletion of these resources and to have a graceful peering tear down. The VirtualKublet can now have the time required for a completed clean-up of the remote cluster.How Has This Been Tested?