Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Client from IAM Identity - AWS 3/3 #758

Merged
merged 1 commit into from Jul 20, 2021
Merged

Create Client from IAM Identity - AWS 3/3 #758

merged 1 commit into from Jul 20, 2021

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jul 19, 2021 •
edited

Description

This pr includes the logic for the creation of a rest.Client from an IAM identity with a bearer token and its periodic refresh

How Has This Been Tested?

  • On EKS cluster, to test that the new values are correctly used
  • Locally on KinD, to test that the non-AWS install is still working

@aleoli aleoli changed the title [WIP] Create Client from IAM Identity [WIP] Create Client from IAM Identity - AWS 3/3 Jul 19, 2021
@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/iam-create-client branch 6 times, most recently from 8276a3f to 1fa0443 Compare July 19, 2021 09:02
@aleoli aleoli marked this pull request as ready for review July 19, 2021 09:08
@aleoli aleoli changed the title [WIP] Create Client from IAM Identity - AWS 3/3 Create Client from IAM Identity - AWS 3/3 Jul 19, 2021
@aleoli
Copy link
Member Author

aleoli commented Jul 20, 2021

/rebase

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 20, 2021
@adamjensenbot adamjensenbot merged commit ffcb9ad into master Jul 20, 2021
@adamjensenbot adamjensenbot deleted the aol/iam-create-client branch July 20, 2021 09:23
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@alacuku alacuku alacuku approved these changes

@giorio94 giorio94 Awaiting requested review from giorio94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aleoli @adamjensenbot @palexster @alacuku