Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign cluster operator performance improvements #814

Merged
merged 3 commits into from Aug 16, 2021
Merged

Foreign cluster operator performance improvements #814

merged 3 commits into from Aug 16, 2021

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Aug 13, 2021 •
edited

Description

This PR introduces different changes to improve the performance of the foreign cluster operator. Specifically:

  • Addition of minimal tracing to detect bottlenecks
  • Reduction of the number of clients, to better exploit the available caches
  • Custom configuration of the client rate limiters, to reduce throttling (customizable by the users)

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Unit testing (new + existing)
  • E2E testing (existing)

@giorio94
Copy link
Member Author

/test

@adamjensenbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 marked this pull request as ready for review August 13, 2021 08:43
@giorio94 giorio94 mentioned this pull request Aug 13, 2021
Merged
2 tasks
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 16, 2021
@adamjensenbot adamjensenbot merged commit 3f2c296 into master Aug 16, 2021
@adamjensenbot adamjensenbot deleted the mio/foreign-cluster branch August 16, 2021 19:06
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@aleoli aleoli aleoli approved these changes

@alacuku alacuku Awaiting requested review from alacuku

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giorio94 @adamjensenbot @palexster @aleoli