New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the idempotence of the tunnel endpoint creator #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @giorio94. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
/test |
giorio94
force-pushed
the
mio/network-performance
branch
from
September 21, 2021 12:12
545bf3f
to
9b0a680
Compare
/test |
alacuku
approved these changes
Sep 21, 2021
/rebase test=true |
adamjensenbot
force-pushed
the
mio/network-performance
branch
from
September 21, 2021 15:23
9b0a680
to
a8b0972
Compare
/test |
2 similar comments
/test |
/test |
/rebase test=true |
adamjensenbot
force-pushed
the
mio/network-performance
branch
from
September 22, 2021 12:58
a8b0972
to
d5fd347
Compare
/test |
palexster
approved these changes
Sep 23, 2021
/rebase test=true |
adamjensenbot
force-pushed
the
mio/network-performance
branch
from
September 23, 2021 08:07
d5fd347
to
a122bbd
Compare
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Sep 23, 2021
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the tunnel endpoint creator, to reduce the overall network setup time thanks to the increase of its idempotence and the removal of the reliance on resyncs.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.