Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Openshift SCC and Install Provider #914

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Add Openshift SCC and Install Provider #914

merged 2 commits into from
Sep 29, 2021

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 27, 2021 •
edited
Loading

Description

This pr includes:

  • some security context permission fix for the Liqo pods
  • OpenShift SCC bindings for privileged pods
  • new openshift provider in the liqoctl install command

How Has This Been Tested?

  • add unit test
  • on an OpenShift (on Azure) Liqo peering to an external k3s cluster

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/openshift-scc branch 2 times, most recently from e727be2 to 1918402 Compare September 28, 2021 12:06
@aleoli
Copy link
Member Author

aleoli commented Sep 28, 2021

/build

@aleoli aleoli force-pushed the aol/openshift-scc branch 2 times, most recently from 3a91149 to 35acf49 Compare September 29, 2021 09:46
@aleoli aleoli mentioned this pull request Sep 29, 2021
Closed
4 tasks
@aleoli
Copy link
Member Author

aleoli commented Sep 29, 2021

/test

@aleoli
Copy link
Member Author

aleoli commented Sep 29, 2021

/test

@aleoli
Copy link
Member Author

aleoli commented Sep 29, 2021

/test

@aleoli aleoli marked this pull request as ready for review September 29, 2021 12:41
@palexster
Copy link
Member

Ref. #909

@palexster palexster self-requested a review September 29, 2021 13:12
@palexster
Copy link
Member

/rebase test=true

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 29, 2021
@adamjensenbot adamjensenbot merged commit 3e060bc into master Sep 29, 2021
@adamjensenbot adamjensenbot deleted the aol/openshift-scc branch September 29, 2021 15:40
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aleoli @adamjensenbot @palexster @giorio94