Fix/issue 289 (complement) #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in the issue liquibase#289, the aggregate functions are not supported by AWS Keyspaces. This fix tries to execute counting queries and if it fails, the same query without the COUNT function is executed and the returned rows are counted programmatically. Also removes code specific to `MSSQLDatabase` in `LockServiceCassandra` obviously not related with Liquibase implementation for Cassandra.
…ized with parameter forceRecheck
|
filipelautert
approved these changes
May 17, 2024
There was a problem hiding this comment.
@maximevw this patch makes a lot of sense, as in core isDatabaseChangeLogLockTableInitialized(boolean) calls the method you override here using false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In complement of the first fix for issue #289.
This overrides the expected method
isDatabaseChangeLogLockTableInitialized(boolean, boolean)ofStandardLockServiceto guarantee usage of the initial patch.See: #289 (comment)