no space after sql comment dashes causes parse error on MySql

[knight]

If you write a migration in raw SQL format and include rollback statements or other adnotations using the -- Mysql fails to recognize it as comments. On the other hand if you introduce the mandatory space after the dashes liquibase does not recognize it as its valid statements.

Please take a look at: http://dev.mysql.com/doc/refman/5.5/en/ansi-diff-comments.html

[nvoxland]

Is this an error with the hibernate extension? Or the general liquibase formatted sql support?

[scm6079]

This issue is a general Liquibase SQL Changeset error.
In a Liquibase SQL change set, you must start with the comment "--liquibase formatted sql". Unfortunately, this is not a well-formed comment in MySQL. The comment must be "-- liquibase formatted sql". If you add the space to the liquibase comment, liquibase does not recognize it. If you continue without the space, all MySQL lint programs (e.g. Intelli-J, etc.) mark those lines as errors, and the scripts can not be executed with MySQL Workbench or other MySQL tools.

For example:

--liquibase formatted sql
--changeset smoore:20140730 dbms:mysql failOnError:true
CREATE TABLE example
(
    company_guid varchar(36) not null,
    anything varchar(80),
    create_ts datetime not null default now(),
    lastmod_ts datetime not null default now(),
    primary key( company_guid )
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

--rollback DROP TABLE example;

Performing a syntax check (or execution) against MySQL returns:

13:55:22 --liquibase formatted sql
Error Code: 1064. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '--liquibase formatted sql' at line 1.

The fix would be to allow liquibase to recognize a space after the "--" in the comment. This is not related to liquibase-hibernate specifically at all.

[scm6079]

This was addressed by CORE-1032.
https://liquibase.jira.com/browse/CORE-1032