PR-2529: Validate LB generates valid DOUBLE PRECISION SQL (mysql). #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDelphiGrl
requested review from
KushnirykOleh,
AlexanderSashchenko and
yodzhubeiskyi
KushnirykOleh
approved these changes
Mar 28, 2022
jnewton03
pushed a commit
that referenced
this pull request
Jun 2, 2022
PR-2529: Validate LB generates valid DOUBLE PRECISION SQL (mysql).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL deprecated DOUBLE PRECISION as of v8.0.17 but Liquibase needs to be able to generate correct SQL for the DOUBLE PRECISION datatype; this PR adds a test to validate correct SQL generation.
This cannot merge until 4.9.0 is released!
Liquibase GitHub Issue
Liquibase GitHub PR