Add Snowflake double to float tests. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
XDelphiGrl
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
This new test goes with Core PR liquibase/liquibase#3703.
APPROVED
KushnirykOleh
requested changes
Jan 25, 2023
There was a problem hiding this comment.
@filipelautert you'll also need to provide expected json file with same name to make it work.
And default workflow doesn't cover Snowflake, so you need to run Snowflake workflow manually for this branch and attach it to PR so it's seen to be working fine
Thanks @KushnirykOleh , json file added! |
suryaaki2
approved these changes
Jan 26, 2023
KushnirykOleh
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to new type DOUBLE specific for Snowkflake