BatchInsert is translated incorrectly for Oracle custom changes

[cdprete]

Liquibase Integration: Spring Boot 2.1.2

Database Vendor & Version: Oracle 12

Description

When creating a custom change that implies the usage of InsertSetStatement for performing multiple insertions at once, the InsertSetGenerator#supports method returns true for Oracle, but the statement that's generated is invalid.
INSERT INTO XYZ(X,Y,Z) VALUES(...),...,(...) is generated rather than something like in https://stackoverflow.com/a/39602

[molivasdat]

Hi @cdprete Thanks for writing up this issue.
If I could get a little more information in the description of what you are trying to do that would be great.
Can you describe how to recreate the problem you are seeing and what you expect the outcome to be?
Another assumption is that you are using Spring Boot 2.1.2 with the version of liquibase it comes with 3.6?
https://mvnrepository.com/artifact/org.springframework.boot/spring-boot/2.1.2.RELEASE
Or did you update Liquibase?

[cdprete]

Hi @molivasdat
Yes, I'm using the version provided by Spring Boot.

What I'm doing is essentially to implement a https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/change/custom/CustomSqlChange.html that returns an array of https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/statement/core/InsertSetStatement.html where, of course, every InsertSetStatement has multiple https://www.javadoc.io/static/org.liquibase/liquibase-core/3.6.0/liquibase/statement/core/InsertStatement.html.

This works fine for Postgres, but with Oracle the DML above is generated as well which is unsupported.

[molivasdat]

Thanks @cdprete for the additional description. We will add this to the list of issues to process. We typically do not go back in versions for updates at least on the community version. Would it be a problem to update the latest version to get something fixed?

[cdprete]

Hi @molivasdat.
It depends on the changes which are introduced.
If there are breaking changes not compatible with such said Spring Boot version, then update won't be an option unfortunately.

[cdprete]

Hi @molivasdat.
Is there any news on this?

[molivasdat]

Hi @cdprete I don't have a PR or fix yet for this. If you have suggested fix that might help move it along faster.

[tati-qalified]

Hello @cdprete, sorry for the late response, we're going through our ticket backlog and testing these issues.
I've been trying to replicate this issue, but I don't think I have enough information to do so. Would you be able to provide some sample code that shows how you're using these objects?
Thank you,
Tatiana

[cdprete]

Hi @tati-qalified.

Not anymore since almost 2y have passed :D

[tati-qalified]

That's fair, thank you anyway!