Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child of #1277: Error loading relative file when logicalFilePath is set (Breaks migration from 3.x to 4.x) #2074

Closed
smainz opened this issue Sep 3, 2021 · 1 comment · Fixed by #2073
Closed

Child of #1277: Error loading relative file when logicalFilePath is set (Breaks migration from 3.x to 4.x) #2074

smainz opened this issue Sep 3, 2021 · 1 comment · Fixed by #2073
Labels
BBroad Broad Issue BNoUpgradePath Cannot upgrade to next version DBAll DBH2 ImpactMedium IntegrationAny PRAssociated Severity3 TypeBug
Milestone
v4.7.0

Comments

@smainz
Copy link

smainz commented Sep 3, 2021

Environment

Liquibase Version: 4.4.3 (and all 4.x, not in 3.x)

Liquibase Integration & Version: any

Liquibase Extension(s) & Version: liquibase-core

Database Vendor & Version: H2 (and all others)

Operating System Type & Version: Windows 10 (and all others)

Description

In #1277 @darkcamper reported an error about loading sql scripts relative to a change log file whicht has a 'logicalFilePath' set.

This has been fixed in #1798 but it has been overlooked that the same error is present in

  • LoadDataChange,
  • CreateProcedureChange and
  • CreateViewChange

A PR to fix this can be found here: #2073

Steps To Reproduce

See #2073

Actual Behavior

See #2073

Expected/Desired Behavior

See #2073
@smainz smainz mentioned this issue Sep 8, 2021
Merged
@molivasdat
Copy link
Contributor

Hi @smainz Thanks for creating this issue. We will add this and the PR to the list of issues we are processing.

@molivasdat molivasdat added this to To Do in Conditioning++ via automation Sep 14, 2021
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Dec 8, 2021
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Dec 8, 2021
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Dec 16, 2021
@nvoxland nvoxland removed this from Done in Conditioning++ Jan 6, 2022
@nvoxland nvoxland added this to the v4.7.0 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BBroad Broad Issue BNoUpgradePath Cannot upgrade to next version DBAll DBH2 ImpactMedium IntegrationAny PRAssociated Severity3 TypeBug
Projects
None yet
Milestone
v4.7.0
3 participants
@nvoxland @smainz @molivasdat