Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shaded libraries to be external dependencies #2852

Open
nvoxland opened this issue May 17, 2022 · 0 comments
Open

Move shaded libraries to be external dependencies #2852

nvoxland opened this issue May 17, 2022 · 0 comments

Comments

@nvoxland
Copy link
Contributor

Description

Liquibase currently shades the following libraries into the liquibase.jar file:

  • opencsv
  • apache commons-lang3
  • apache commons-text
  • apache commons-collections4
  • apache commons-codec
  • jsqlparser
  • jackson xml libraries

primarily because prior to #2850 it was difficult to manage external dependencies in the CLI.

Now that that issue has been lessened, we can manage those dependencies in a more standard manner.

Expected Results

  • No shaded classes in liquibase.jar
  • Libraries are included in the CLI's internal/lib directory
  • org.liquibase:liquibase-core's pom.xml includes them as non-optional dependencies
@kataggart kataggart added the sbom label Jul 20, 2022
@kataggart kataggart removed the sbom label Jul 28, 2022
@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 28, 2022
@kataggart kataggart added this to the Epic: SBOM MVP milestone Jul 28, 2022
@kataggart kataggart removed this from To Do in Conditioning++ Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants