Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquibase 4.21 breaks prompting for password during update #4224

Open
1 of 2 tasks
joschug opened this issue May 8, 2023 · 2 comments
Open
1 of 2 tasks

Liquibase 4.21 breaks prompting for password during update #4224

joschug opened this issue May 8, 2023 · 2 comments

Comments

@joschug
Copy link

joschug commented May 8, 2023

Search first

  • I searched and no similar issues were found

Description

Since 3.0.6, Liquibase supports prompting for arguments, e.g. passwords, when specifying the magic value "PROMPT". We use this to query the password of the production database before installation. This does not work anymore with 4.21, liquibase update does not prompt for the password and instead fails to connect with "invalid username or password".

liquibase status still works as expected. Browsing through the recent changes, I assume this is caused by the refactoring around the command framework.

Steps To Reproduce

liquibase --url=somedatabase --username=test --password=PROMPT update

This should prompt for user input, but it doesn't.

Expected/Desired Behavior

Liquibase should prompt for user input, as it did before 4.21.

Liquibase Version

4.21.1

Database Vendor & Version

Oracle 19c

Liquibase Integration

CLI

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

macOS/Linux

Additional Context

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR (Thank you!)
@nvoxland
Copy link
Contributor

That probably got lost when we introduced the UIService with 4.0? Originally it didn't have a way to prompt since we generally try to avoid that.

Since then, we've added that into the UIService so the functionality could be added back.

@joschug
Copy link
Author

joschug commented Jun 12, 2023

@nvoxland My bad, I should have made more clear that this used to work up until version 4.20. It's a recent regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Open Issues
Development

No branches or pull requests

2 participants