Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults for GenerateChangeLogTask.includeTablespace have changed #4481

Open
1 of 2 tasks
SonReimer opened this issue Jul 11, 2023 · 0 comments
Open
1 of 2 tasks

Defaults for GenerateChangeLogTask.includeTablespace have changed #4481

SonReimer opened this issue Jul 11, 2023 · 0 comments

Comments

@SonReimer
Copy link

SonReimer commented Jul 11, 2023

Search first

  • I searched and no similar issues were found

Description

Between 4.19 and 4.20 Liquibase.generateChangeLog has been implemented with a CommandScope not using the given DiffOutputControl but a creating a new one initializing includeTablespace from CommandScope-Arguments.

  • It is not possible to add Arguments to the internally created CommandScope and the default is false.
  • That does not seem downwardscompatible to me.

Steps To Reproduce

We are creating a Changelog from a hibernate mapping using our own database class and are applying tablespaces when mapping from hibernate tables to liquibase tables.
But in class MissingTableChangeGenerator.fixMissing(...) tablespace is not propagated to the change because includeTablespace is false in DiffOutputControl.

Expected/Desired Behavior

We expect that setting GenerateChangelogTask.includeTabelspace is propagated to execution with CommandScope.

Liquibase Version

4.20

Database Vendor & Version

Hibernate

Liquibase Integration

ant

Liquibase Extensions

liquibase-hibernate6

OS and/or Infrastructure Type/Provider

Windows

Additional Context

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR (Thank you!)
@kevin-atx kevin-atx added this to the JavaAPI milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Open Issues
Development

No branches or pull requests

2 participants